[Kde-hardware-devel] Review Request 111699: Fixed "no such signal" message in UPowerManager at startup

[Albert Vaca Cintora]

> On July 26, 2013, 12:05 p.m., Lukáš Tinkl wrote:
> > I'm curious why this is needed, after all, your change just uses a different mechanism to connect the signals

I'm not sure if the current code actually works, but it gives that error in runtime so I think it is better to change it anyway.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111699/#review36528
-----------------------------------------------------------


On July 25, 2013, 10:36 p.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111699/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 10:36 p.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> The following message was shown when UPowerManager was instantiated (e.g.: when kded4 starts):
> 
> Object::connect: No such signal QDBusAbstractInterface::DeviceAdded(QString) in /home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:67
> Object::connect: No such signal QDBusAbstractInterface::DeviceRemoved(QString) in /home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:69
> 
> This patch fixes to connection to the mentioned DBus signal (the normal connect construction that was used doesn't work for dbus signals) so this message doesn't appear anymore, and probably fixes the underlying functionality that required this signal to be connected.
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/upower/upowermanager.cpp bae234b 
> 
> Diff: http://git.reviewboard.kde.org/r/111699/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130726/560ecbf2/attachment-0001.html>