[Kde-hardware-devel] Review Request 111575: added basic windows support

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111575/#review36136
-----------------------------------------------------------



solid/solid/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111575/#comment26759>

    Please make the else() and endif() condition empty. It is not necessary anymore and we decided to prefer to hav ethem empty.


- Alexander Neundorf


On July 18, 2013, 3:46 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111575/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 3:46 p.m.)
> 
> 
> Review request for kdewin and Solid.
> 
> 
> Description
> -------
> 
> added basic windows support
> 
> 
> Diffs
> -----
> 
>   solid/solid/networking_win.cpp PRE-CREATION 
>   solid/solid/networking_p.h 5f4ce99c5df228049eccf1d651e08c0a13d3b7ee 
>   solid/solid/CMakeLists.txt ab5bfd4350a0f1a86c5221e4bbe154e9b5d69e98 
> 
> Diff: http://git.reviewboard.kde.org/r/111575/diff/
> 
> 
> Testing
> -------
> 
> needs some more testing as I currently only have remote access I could not test what happens if I unplug the Ethernet cable
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130718/a5cf336f/attachment.html>