[Kde-hardware-devel] Review Request 111295: Secrets compability between plasma-nm and networkmanagement

Lamarque Souza lamarque at kde.org
Mon Jul 1 16:55:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111295/#review35378
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza


On June 29, 2013, 8:11 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111295/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 8:11 a.m.)
> 
> 
> Review request for Solid, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Description
> -------
> 
> As I promised, here is a patch that should fix secrets compatibility between both NM applets. But there is one little difference which is that VPN secrets has "secrets" key in KWallet entry (according to VPN setting property) instead of "VpnSecrets". Everything is done automatically at first start and there is no information about how many secrets were imported etc.
> 
> 
> Diffs
> -----
> 
>   editor/connectioneditor.h f8fb13f 
>   editor/connectioneditor.cpp ee352d2 
>   kded/secretagent.cpp dc6f648 
> 
> Diff: http://git.reviewboard.kde.org/r/111295/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130701/bd5db9b1/attachment.html>


More information about the Kde-hardware-devel mailing list