[Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil
Xuetian Weng
wengxt at gmail.com
Mon Jan 28 17:41:24 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review26323
-----------------------------------------------------------
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp
<http://git.reviewboard.kde.org/r/108407/#comment20025>
I suggest to use xml generated dbus interface, not QDBusInterface as dynamic one. It will avoid runtime introspection on dbus.
- Xuetian Weng
On Jan. 28, 2013, 4:45 p.m., Lukáš Tinkl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108407/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 4:45 p.m.)
>
>
> Review request for Solid and Dario Freddi.
>
>
> Description
> -------
>
> This patch adds support for systemd-login1 service to Powerdevil's upower backend. The main purpose is that UPower will be soon dropping support[1] for suspend/resume features so we have to rely on systemd. With this login1, we are also gaining support for HybridSleep, where implemented by the system.
>
> One caveat: the current login1 implementation doesn't support[2] emitting the "resume from suspend" signal
>
> [1] http://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html
> [2] http://www.freedesktop.org/wiki/Software/systemd/inhibit
>
>
> This addresses bug https://bugzilla.redhat.com/show_bug.cgi?id=859227.
> http://bugs.kde.org/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=859227
>
>
> Diffs
> -----
>
> powerdevil/daemon/BackendConfig.cmake 5dbe6f6
> powerdevil/daemon/backends/upower/login1suspendjob.h PRE-CREATION
> powerdevil/daemon/backends/upower/login1suspendjob.cpp PRE-CREATION
> powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd
> powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b
> powerdevil/daemon/backends/upower/upowersuspendjob.h bbe2f45
> powerdevil/daemon/backends/upower/upowersuspendjob.cpp 536a7e1
>
> Diff: http://git.reviewboard.kde.org/r/108407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lukáš Tinkl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130128/5d92ad20/attachment.html>
More information about the Kde-hardware-devel
mailing list