[Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/
-----------------------------------------------------------

(Updated Jan. 14, 2013, 1:52 p.m.)


Review request for Solid and Dario Freddi.


Changes
-------

Use a QWeakPointer, get rid of the boolean, use async calls in the suspend job class


Description
-------

This patch adds support for systemd-login1 service to Powerdevil's upower backend. The main purpose is that UPower will be soon dropping support[1] for suspend/resume features so we have to rely on systemd. With this login1, we are also gaining support for HybridSleep, where implemented by the system.

One caveat: the current login1 implementation doesn't support[2] emitting the "resume from suspend" signal

[1] http://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html
[2] http://www.freedesktop.org/wiki/Software/systemd/inhibit


This addresses bug https://bugzilla.redhat.com/show_bug.cgi?id=859227.
    http://bugs.kde.org/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=859227


Diffs (updated)
-----

  powerdevil/daemon/BackendConfig.cmake 5dbe6f6 
  powerdevil/daemon/backends/upower/login1suspendjob.h PRE-CREATION 
  powerdevil/daemon/backends/upower/login1suspendjob.cpp PRE-CREATION 
  powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd 
  powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b 
  powerdevil/daemon/backends/upower/upowersuspendjob.h bbe2f45 
  powerdevil/daemon/backends/upower/upowersuspendjob.cpp fa64ab0 

Diff: http://git.reviewboard.kde.org/r/108407/diff/


Testing
-------


Thanks,

Lukáš Tinkl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130114/3d90aa24/attachment.html>