[Kde-hardware-devel] Review Request 108395: Fix Output::Rotation enumeration to match xrandr values

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108395/#review25411
-----------------------------------------------------------


Good catch.

However you have to update the KScreen KCM too to match the new angles. Check Output.qml and OutputControls.qml files. Post a separate review please and ship them together (when you get 'ship it' on the other one)

- Dan Vrátil


On Jan. 13, 2013, 8:31 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108395/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 8:31 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dan Vrátil.
> 
> 
> Description
> -------
> 
> Once I got my orientation data engine using libkscreen to rotate the X screen I found it was rotating the opposite of what I told it.  If I executed setRotation(KScreen::Output::Left) xrandr showed it was rotated to the right and vice versa.  It turned out the Rotation enumeration values were opposite of those expected by xrandr.  This patch fixes that.
> 
> 
> Diffs
> -----
> 
>   src/output.h 117ea79584075cb5a365f94d6c634f145e30998c 
> 
> Diff: http://git.reviewboard.kde.org/r/108395/diff/
> 
> 
> Testing
> -------
> 
> It works much better now.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130113/a3c36728/attachment-0001.html>