[Kde-hardware-devel] Review Request: Make sure we always have at least one output enabled

Àlex Fiestas afiestas at kde.org
Wed Jan 2 09:52:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108062/#review24418
-----------------------------------------------------------

Ship it!


Besides removing the kcm line, the patch looks fine.

- Àlex Fiestas


On Jan. 1, 2013, 8:35 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108062/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 8:35 p.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> When restoring a config, make sure that we have at least one output enabled. There's nothing worse then ending up with all screens disabled (for users who don't know how to use xrandr ;-)
> 
> Fixes the issue that when you unplugging external monitor while laptop lid is closed and open the lid, the laptop monitor is disabled.
> 
> 
> This addresses bug 312410.
>     http://bugs.kde.org/show_bug.cgi?id=312410
> 
> 
> Diffs
> -----
> 
>   kcm/qml/OutputView.qml e12d526 
>   kded/generator.cpp 979e192 
>   tests/testgenerator.cpp 6dd3574 
> 
> Diff: http://git.reviewboard.kde.org/r/108062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130102/640693d6/attachment.html>


More information about the Kde-hardware-devel mailing list