[Kde-hardware-devel] Review Request 109126: Cache whether screen powersaving is inhibited

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109126/#review27982
-----------------------------------------------------------


Looks good from my POV but I'd like to wait for Dario's final "ship it".

- Lukáš Tinkl


On Feb. 24, 2013, 6:40 p.m., Oliver Henshaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109126/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 6:40 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Cache whether screen powersaving is inhibited
> 
> DPMSAction disables or enables DPMS (and sets timeouts) as appropriate
> when inhibition policy changes. As setting DPMS timeouts resets the
> timer this will delay the time at which DPMS activates. But this is only
> necessary if the ChangeScreenSettings inhibition changed.
> 
> Chrome sets short-lived InterruptSession inhibitions while uploading
> data. This has the effect of indefinitely delaying DPMS activation.
> 
> So cache the current screen inhibition state and only decide whether to
> enable or disable DPMS if the new state is different.
> 
> BUG: 314250
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=314250.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=314250
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/dpms/powerdevildpmsaction.h ad6add8b797eb4ecd59e407bade93862160ef23c 
>   powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 55689b5bcea61a7a982ec270c997c6b1336867ee 
> 
> Diff: http://git.reviewboard.kde.org/r/109126/diff/
> 
> 
> Testing
> -------
> 
> Tested that inhibition is correctly cached and that inhibiting session power saving does not affect DPMS idle time. Tested that the DPMS action continues to react properly when screen inhibition changes. Tested unloading and loading powerdevil module with and without active inhibitions.
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130224/1c6c3a76/attachment.html>