[Kde-hardware-devel] Review Request 108894: [Draft] Add Battery OSD that allows the user to quickly peak into the battery percentage any time

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108894/#review27444
-----------------------------------------------------------


I'm not happy with it, UI-wise, for the following reasons:

- the OSD is an indicator of the user changing a setting, not a status display
- the feature is entirely hidden, meaning that nobody will know it, notice it, and use it
- It solves a fringe case

I see how it can be useful to solve a very specific usecase, but it's not a feature that should be available to the general public (after all, being able to see the battery is also only one keystroke away)

- Sebastian Kügler


On Feb. 10, 2013, 10:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108894/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2013, 10:54 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> This draft patch is for adding a Battery OSD the user can trigger using Meta+B any time to show the battery percentage anytime without disrupting the workflow. My usecase for this is when I am watching fullscreen flash videos, they cause quite some drain on battery, but when I want to look how much battery is left, I have to either leave fullscreen and peak, or (as I do) press some shortcut assigned to the battery widget. Both will cause the fullscreen to exit. Even more useful when playing a fullscreen game that you don't want (or can) to leave.
> This adds a little OSD similar to the brightness OSD that shows the battery percentage when the user presses Meta+B.
> 
> This patch is draft because I first wanted to know your opinion on this before I start completing it (ie. showing the battery icon in the same way the battery widget does), atm it's the brightness icon.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/powerdevilcore.h dd5d674 
>   powerdevil/daemon/powerdevilcore.cpp 6be6a8b 
>   powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 323905d 
>   powerdevil/daemon/actions/bundled/keyboardbrightnesscontrol.cpp 8249b17 
>   powerdevil/daemon/brightnessosdwidget.h 40166d4 
>   powerdevil/daemon/brightnessosdwidget.cpp 1474018 
>   powerdevil/daemon/powerdevilbackendinterface.h 00ccada 
> 
> Diff: http://git.reviewboard.kde.org/r/108894/diff/
> 
> 
> Testing
> -------
> 
> When I press Meta+B I get an OSD showing my current battery percentage.
> 
> 
> File Attachments
> ----------------
> 
> Battery OSD
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/10/batteryosd.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130214/199a2c1a/attachment.html>