[Kde-hardware-devel] Review Request 108232: Make Keyboard Backlight Control Keys Work

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108232/#review27246
-----------------------------------------------------------


A similar feature has been commited and will be available in KDE 4.11. This review can thus be closed?

- Kai Uwe Broulik


On Jan. 6, 2013, 8:45 p.m., Andreas Lauser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108232/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 8:45 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> This partially fixes bug #288179. Partially, because currently there
> is no GUI yet for setting the keyboard backlight, and the OSD does not
> show the correct icon when using the special keys for keyboard
> backlight control.
> 
> For the OSD issue (it shows a monitor instead of a keyboard icon), I
> could not figure out how to update the relevant code. AFAICS the problem is
> that powerdevil only emits the brightnessChanged(float) signal, but
> does not seem to implement the OSD itself; further, the
> brightnessChanged(float) signal seems to be a part of Solid but I did
> not want to change the solid API, as IMHO this might potentially break too many
> things.
> 
> 
> This addresses bug 288179.
>     http://bugs.kde.org/show_bug.cgi?id=288179
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/hal/powerdevilhalbackend.h be00217 
>   powerdevil/daemon/backends/hal/powerdevilhalbackend.cpp 23878c3 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b 
>   powerdevil/daemon/powerdevilbackendinterface.h 91519a9 
>   powerdevil/daemon/powerdevilcore.h 77c3f2f 
>   powerdevil/daemon/powerdevilcore.cpp 2dcdbc6 
> 
> Diff: http://git.reviewboard.kde.org/r/108232/diff/
> 
> 
> Testing
> -------
> 
> I've currently only tested this patch on my samsung 900x3a laptop, so
> your milage may vary. On this laptop with Kubuntu 12.10 the special keys worked with this patch, but I had to
> first instruct udev to recognize the special keys using
> 
> sudo /lib/udev/keymap "/dev/input/event4" /lib/udev/keymaps/samsung-900x3a
> 
> 
> Thanks,
> 
> Andreas Lauser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130211/0114fca2/attachment.html>