[Kde-hardware-devel] Review Request 114679: Delete stuff correctly

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114679/#review46209
-----------------------------------------------------------

Ship it!


Looks good, please go ahead.

- Àlex Fiestas


On Dec. 26, 2013, 11:32 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114679/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 11:32 p.m.)
> 
> 
> Review request for Solid and Daniel Nicoletti.
> 
> 
> Repository: colord-kde
> 
> 
> Description
> -------
> 
> ==5515== Mismatched free() / delete / delete []
> ==5515==    at 0x4C2BADC: operator delete(void*) (vg_replace_malloc.c:480)
> ==5515==    by 0x1BB7E189: Output::readEdidData() (Output.cpp:169)
> ==5515==    by 0x1BB8629C: ColorD::addOutput(QSharedPointer<Output> const&) (ColorD.cpp:183)
> ==5515==    by 0x1BB88031: ColorD::checkOutputs() (ColorD.cpp:475)
> ==5515==    by 0x7308A3D: QObject::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x5F51DAB: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.4)
> ==5515==    by 0x5F5841F: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.4)
> ==5515==    by 0x5962A89: KApplication::notify(QObject*, QEvent*) (kapplication.cpp:311)
> ==5515==    by 0x72F054C: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x72F3A9C: QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x731DCC2: postEventSourceDispatch(_GSource*, int (*)(void*), void*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x9C6AB13: g_main_context_dispatch (gmain.c:3068)
> ==5515==  Address 0x1719ae00 is 0 bytes inside a block of size 128 alloc'd
> ==5515==    at 0x4C2AFE7: operator new[](unsigned long) (vg_replace_malloc.c:363)
> ==5515==    by 0x1BB7DC23: Output::readEdidData(unsigned long&) (Output.cpp:231)
> ==5515==    by 0x1BB7E0D3: Output::readEdidData() (Output.cpp:157)
> ==5515==    by 0x1BB8629C: ColorD::addOutput(QSharedPointer<Output> const&) (ColorD.cpp:183)
> ==5515==    by 0x1BB88031: ColorD::checkOutputs() (ColorD.cpp:475)
> ==5515==    by 0x7308A3D: QObject::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x5F51DAB: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.4)
> ==5515==    by 0x5F5841F: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.4)
> ==5515==    by 0x5962A89: KApplication::notify(QObject*, QEvent*) (kapplication.cpp:311)
> ==5515==    by 0x72F054C: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x72F3A9C: QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515==    by 0x731DCC2: postEventSourceDispatch(_GSource*, int (*)(void*), void*) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
> ==5515== 
> 
> 
> Diffs
> -----
> 
>   colord-kded/Output.cpp cb59ef3 
> 
> Diff: https://git.reviewboard.kde.org/r/114679/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131227/b8004ede/attachment-0001.html>