[Kde-hardware-devel] Review Request 114678: Delete data correctly

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114678/
-----------------------------------------------------------

Review request for Solid, Àlex Fiestas and Dan Vrátil.


Repository: libkscreen


Description
-------

==5515== Mismatched free() / delete / delete []
==5515==    at 0x4C2BADC: operator delete(void*) (vg_replace_malloc.c:480)
==5515==    by 0x2572172D: XRandROutput::edid() const (xrandroutput.cpp:119)
==5515==    by 0x25716CB7: XRandR::edid(int) const (xrandr.cpp:164)
==5515==    by 0x252E6E9B: KScreen::Output::edid() const (output.cpp:407)
==5515==    by 0x25088C93: Serializer::outputId(KScreen::Output const*) (serializer.cpp:213)
==5515==    by 0x25089610: Serializer::currentId() (serializer.cpp:48)
==5515==    by 0x25089671: Serializer::configExists() (serializer.cpp:61)
==5515==    by 0x25088531: KScreenDaemon::applyConfig() (daemon.cpp:93)
==5515==    by 0x73046D7: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
==5515==    by 0x73046D7: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
==5515==    by 0x25092D0D: Device::isLidClosedFetched(QDBusPendingCallWatcher*) (device.cpp:148)
==5515==    by 0x73046D7: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
==5515==  Address 0x3399d2c0 is 0 bytes inside a block of size 128 alloc'd
==5515==    at 0x4C2AFE7: operator new[](unsigned long) (vg_replace_malloc.c:363)
==5515==    by 0x25716ECE: XRandR::getXProperty(_XDisplay*, unsigned long, unsigned long, unsigned long&) (xrandr.cpp:194)
==5515==    by 0x25716F48: XRandR::outputEdid(int, unsigned long&) (xrandr.cpp:211)
==5515==    by 0x257216EC: XRandROutput::edid() const (xrandroutput.cpp:116)
==5515==    by 0x25716CB7: XRandR::edid(int) const (xrandr.cpp:164)
==5515==    by 0x252E6E9B: KScreen::Output::edid() const (output.cpp:407)
==5515==    by 0x25088C93: Serializer::outputId(KScreen::Output const*) (serializer.cpp:213)
==5515==    by 0x25089610: Serializer::currentId() (serializer.cpp:48)
==5515==    by 0x25089671: Serializer::configExists() (serializer.cpp:61)
==5515==    by 0x25088531: KScreenDaemon::applyConfig() (daemon.cpp:93)
==5515==    by 0x73046D7: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)
==5515==    by 0x73046D7: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.4)


Diffs
-----

  backends/xrandr/xrandroutput.cpp 384d702 

Diff: https://git.reviewboard.kde.org/r/114678/diff/


Testing
-------

Compiles


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131226/e388852f/attachment.html>