[Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Àlex Fiestas]

> On Dec. 18, 2013, 6:02 p.m., Àlex Fiestas wrote:
> > Add a comment explaining why we have to deal with upstart if the method is called "checkSsytemdVersion".
> > 
> > Once that's done, please commit.

Oh and also explain it in the commit message, plus say that this won't affect systems using systemd because the systemd check is before the upstart one (just so nobdoy yells at us for the commit)


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/#review45912
-----------------------------------------------------------


On Dec. 10, 2013, 6:25 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114393/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 6:25 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on upstart systems by just fixing the check for the version inside the upower daemon.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: http://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> -------
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131218/4fa3ebc6/attachment.html>