[Kde-hardware-devel] Review Request 111918: Support for keyboards and pointers in udev backend

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111918/#review38796
-----------------------------------------------------------



tier1/solid/src/solid/backends/fakehw/fakepointingdevice.cpp
<http://git.reviewboard.kde.org/r/111918/#comment28653>

    if (x == QLatin1String(...))



tier1/solid/src/solid/keyboard.h
<http://git.reviewboard.kde.org/r/111918/#comment28652>

    I think these properties should be marked as CONSTANT
    
    In general things should either have a NOTIFY signal or be marked as CONSTANT, QML can give a runtime warning about this when used.


- David Edmundson


On Aug. 28, 2013, 2:40 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111918/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 2:40 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Kevin Ottens.
> 
> 
> Description
> -------
> 
> This patch adds the support (to solid and udev backend) for:
>  - keyboards
>  - pointer (mice, tablets, touchpads and touch-screens)
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/CMakeLists.txt 7427aca 
>   tier1/solid/src/solid/backends/fakehw/fakedevice.cpp e1a386a 
>   tier1/solid/src/solid/backends/fakehw/fakekeyboard.h PRE-CREATION 
>   tier1/solid/src/solid/backends/fakehw/fakekeyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/fakehw/fakepointingdevice.h PRE-CREATION 
>   tier1/solid/src/solid/backends/fakehw/fakepointingdevice.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/hal/haldevice.cpp d1e48fb 
>   tier1/solid/src/solid/backends/hal/haldeviceinterface.h 1d70187 
>   tier1/solid/src/solid/backends/udev/udevdevice.cpp 8e5f9e9 
>   tier1/solid/src/solid/backends/udev/udevkeyboard.h PRE-CREATION 
>   tier1/solid/src/solid/backends/udev/udevkeyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/udev/udevmanager.cpp e6270a6 
>   tier1/solid/src/solid/backends/udev/udevpointingdevice.h PRE-CREATION 
>   tier1/solid/src/solid/backends/udev/udevpointingdevice.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/udisks/udisksdeviceinterface.h 004732c 
>   tier1/solid/src/solid/backends/upower/upowerdeviceinterface.h 8c6fe5e 
>   tier1/solid/src/solid/device.cpp d9f3c6d 
>   tier1/solid/src/solid/deviceinterface.h c94ebbd 
>   tier1/solid/src/solid/deviceinterface.cpp 2cbd777 
>   tier1/solid/src/solid/ifaces/keyboard.h PRE-CREATION 
>   tier1/solid/src/solid/ifaces/keyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/ifaces/pointingdevice.h PRE-CREATION 
>   tier1/solid/src/solid/ifaces/pointingdevice.cpp PRE-CREATION 
>   tier1/solid/src/solid/keyboard.h PRE-CREATION 
>   tier1/solid/src/solid/keyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/keyboard_p.h PRE-CREATION 
>   tier1/solid/src/solid/pointingdevice.h PRE-CREATION 
>   tier1/solid/src/solid/pointingdevice.cpp PRE-CREATION 
>   tier1/solid/src/solid/pointingdevice_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111918/diff/
> 
> 
> Testing
> -------
> 
> On two systems
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130828/3871f7ac/attachment-0001.html>