[Kde-hardware-devel] Review Request 111918: Support for keyboards and pointers in udev backend

[Ivan Čukić]

> On Aug. 8, 2013, 12:20 p.m., Lamarque Souza wrote:
> > tier1/solid/src/solid/backends/udev/udevkeyboard.h, line 39
> > <http://git.reviewboard.kde.org/r/111918/diff/1/?file=176451#file176451line39>
> >
> >     missing explicit modifier.

No other class in the same folder has explicit modifier for the constructor. This patch follows the project style. We could make an additional patch for adding explicits to the whole codebase of solid.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111918/#review37340
-----------------------------------------------------------


On Aug. 8, 2013, 9:04 a.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111918/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 9:04 a.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Kevin Ottens.
> 
> 
> Description
> -------
> 
> This patch adds the support (to solid and udev backend) for:
>  - keyboards
>  - pointer (mice, tablets, touchpads and touch-screens)
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/CMakeLists.txt 7427aca 
>   tier1/solid/src/solid/backends/fakehw/fakedevice.cpp e1a386a 
>   tier1/solid/src/solid/backends/fakehw/fakekeyboard.h PRE-CREATION 
>   tier1/solid/src/solid/backends/fakehw/fakekeyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/fakehw/fakepointer.h PRE-CREATION 
>   tier1/solid/src/solid/backends/fakehw/fakepointer.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/hal/haldevice.cpp d1e48fb 
>   tier1/solid/src/solid/backends/hal/haldeviceinterface.h 1d70187 
>   tier1/solid/src/solid/backends/udev/udevdevice.cpp 8e5f9e9 
>   tier1/solid/src/solid/backends/udev/udevkeyboard.h PRE-CREATION 
>   tier1/solid/src/solid/backends/udev/udevkeyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/udev/udevmanager.cpp e6270a6 
>   tier1/solid/src/solid/backends/udev/udevpointer.h PRE-CREATION 
>   tier1/solid/src/solid/backends/udev/udevpointer.cpp PRE-CREATION 
>   tier1/solid/src/solid/backends/udisks/udisksdeviceinterface.h 004732c 
>   tier1/solid/src/solid/backends/upower/upowerdeviceinterface.h 8c6fe5e 
>   tier1/solid/src/solid/device.cpp d9f3c6d 
>   tier1/solid/src/solid/deviceinterface.h c94ebbd 
>   tier1/solid/src/solid/deviceinterface.cpp 2cbd777 
>   tier1/solid/src/solid/ifaces/keyboard.h PRE-CREATION 
>   tier1/solid/src/solid/ifaces/keyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/ifaces/pointer.h PRE-CREATION 
>   tier1/solid/src/solid/ifaces/pointer.cpp PRE-CREATION 
>   tier1/solid/src/solid/keyboard.h PRE-CREATION 
>   tier1/solid/src/solid/keyboard.cpp PRE-CREATION 
>   tier1/solid/src/solid/keyboard_p.h PRE-CREATION 
>   tier1/solid/src/solid/pointer.h PRE-CREATION 
>   tier1/solid/src/solid/pointer.cpp PRE-CREATION 
>   tier1/solid/src/solid/pointer_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111918/diff/
> 
> 
> Testing
> -------
> 
> On two systems
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130808/5f8c3161/attachment-0001.html>