[Kde-hardware-devel] Review Request: Fix removable property in soliddevice dataengine with HAL backend (on FreeBSD)

[Alberto Villa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106378/
-----------------------------------------------------------

Review request for Solid.


Description
-------

Current hack to check for removable property in StorageAccess devices goes up only one level to search for the StorageDrive device. This works fine with UDev, but not with HAL, which can have (at least on FreeBSD, where I'm testing it) a StorageVolume device in the middle. Going up the whole tree of the Block device ensures that we eventually get to the StorageDrive one to fetch the correct removable property.

While here, I'd like to ask why only removable is set (in a not so convincing way, as a removable device can be non-hotpluggable as far as I know) instead of both removable and hotpluggable, as done few lines above.

If approved, I'd like to commit this also to 4.9.


Diffs
-----

  plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 86f123c 

Diff: http://git.reviewboard.kde.org/r/106378/diff/


Testing
-------

Tested successfully on FreeBSD 10-CURRENT r239665 with KDE SC 4.9.0: my USB flash drives now appear in the device notifier plasmoid (and a console.log() in the plasmoid itself confirms that the device now has the Removable property).

I also double-checked with a UDev-backed `solid-hardware list details` log that the logic correctly applies to UDev.


Thanks,

Alberto Villa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20120908/9a7724f5/attachment.html>