[Kde-hardware-devel] Review Request: Don't give InterruptSession special treatment

[Oliver Henshaw]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107022/
-----------------------------------------------------------

Review request for Solid.


Description
-------

Don't give InterruptSession special treatment

Revert "Override ck check if the last active user requested to shutdown
the session." and matching check in systemd support.

Allowing InterruptSession when another consolekit/loginctl session is
Active means that PowerDevil may attempt to autosuspend the system from
the Inactive session. Normally polkit disallows this and no harm is done
but some systems have a "ResultInactive=auth_admin" policy. This will
bring up a root dialogue on the inactive session, which is annoying and
unnecessary at best. Due to a bug(?) this will also block upower suspend
actions in the active session.

This reverts commit 2606ff0045470d360a2ad4ad8aeb2819f653676f. It's not
clear whether https://bugs.kde.org/show_bug.cgi?id=277774 was ever fixed
by that commit.

CCBUG: 298712


Diffs
-----

  powerdevil/daemon/powerdevilpolicyagent.cpp 70588dbcd7f02add12eb957f00decb9f0db9540a 

Diff: http://git.reviewboard.kde.org/r/107022/diff/


Testing
-------

Tested timed and explicit hibernate works as expected with (a) one active session and (b) with one active and one inactive session.


Thanks,

Oliver Henshaw

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121024/84b90096/attachment.html>