[Kde-hardware-devel] Review Request: Silence "Profile foo could not activate bar which is a non-existent action" message

[Oliver Henshaw]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106863/#review20372
-----------------------------------------------------------


I've been mulling a fix for this myself, but not put code down yet. Here's some thoughts:

Would it be better to detect DPMS capabilities in the profile generator and keep the notification? I see it already detects the presence of batteries. And IIRC the kcm configuration page doesn't offer DPMS action settings if DPMS is not available.

The notification should remain, I think, as they're an indication of a real problem (either misconfiguration or a bug).

As for the ugly (and often too brief to read) passivepopup during login, is there a way to fix this centrally? Perhaps detecting that login is in progress (somehow) and queuing notifications for later?

- Oliver Henshaw


On Oct. 15, 2012, 3:14 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106863/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 3:14 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> That message usually appears when starting before the Desktop is up, causing an ugly 1990's passivepopup dialog on the screen, and its contents are not really novice-user-resolvable.
> On my machine it always claims "The profile Battery tried to activate DPMSControl which is a non-existent action.", which is when I compile powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not met here) and so the action floats around in the config but cannot be triggered anyways. (Imho this is a really infamous message, have seen it quite often on other machines *duck*). All the other actions seem to be installed anyways, so this missing action poses no threat. I guess a kWarning would be sufficient for this.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/powerdevilcore.cpp 058bfc6 
> 
> Diff: http://git.reviewboard.kde.org/r/106863/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> The previous passivepopup does not appear anymore. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121015/fa0d845d/attachment.html>