[Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106783/#review20266
-----------------------------------------------------------


This review has been submitted with commit 6611d784b173bdcb117dc03ce06c27a454a087db by Kai Uwe Broulik to branch master.

- Commit Hook


On Oct. 10, 2012, 3:35 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106783/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2012, 3:35 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> This little patch hides the config options for battery levels altogether when there is no battery present. Reducses visual clutter.
> 
> 
> Diffs
> -----
> 
>   powerdevil/kcmodule/global/GeneralPage.cpp 5ff3f4d 
> 
> Diff: http://git.reviewboard.kde.org/r/106783/diff/
> 
> 
> Testing
> -------
> 
> Didn’t test whether the elements are really hidden in the real condition (Have a notebook only here, but I know that if works) but commented out the if and the elements are all properly removed.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121013/2be9fb43/attachment.html>