[Kde-hardware-devel] Review Request: Prevent button action from enabling disabled DPMS

[Oliver Henshaw]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106794/
-----------------------------------------------------------

Review request for Solid.


Description
-------

Prevent button action from enabling disabled DPMS

Button actions call triggerImpl, which leaves DPMS enabled. It can't be
disabled until return from idle, as that would wake the screen. Solve
this by explicitly setting DPMS timeouts to zero when DPMS is meant to
be disabled - i.e. when unloading the action or when screen power
management is inhibited.

CCBUG: 295164


Diffs
-----

  powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp a16bf7ee254b9a40c6f033c93e5ca63226469e6e 

Diff: http://git.reviewboard.kde.org/r/106794/diff/


Testing
-------

(in combination with review request  #106793 )

Set power button to "Turn off screen" then press it, wait for the screen to turn off then wake the system from idle. Check 'xset -q' has expected values in various situations, e.g.:

- when timed screen power saving is enabled
- when it's disabled
- when it hasn't been enabled in this login
- when screen power saving is inhibited
- when profile or configuration or activity change
- when profile or configuration or activity change when screen power saving is inhibited

I think this covers all cases, but please hammer away with it and see if you can find any problems I've missed.


Thanks,

Oliver Henshaw

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121012/652d8b13/attachment.html>