[Kde-hardware-devel] Review Request: Add FreeBSD implementation to backlighthelper

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106790/#review20184
-----------------------------------------------------------

Ship it!


Looks good to go, after fixing those two small issues please push to master and branch. Thanks!


powerdevil/daemon/backends/upower/backlighthelper.h
<http://git.reviewboard.kde.org/r/106790/#comment15959>

    I would use something less generic for the names, such as m_sysCtlDevice, or stuff like that



powerdevil/daemon/backends/upower/backlighthelper.cpp
<http://git.reviewboard.kde.org/r/106790/#comment15958>

    POD types are better off without const refs (foreach(int level, m_levels))


- Dario Freddi


On Oct. 11, 2012, 1:59 a.m., Alberto Villa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106790/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 1:59 a.m.)
> 
> 
> Review request for Solid and Dario Freddi.
> 
> 
> Description
> -------
> 
> This patch should bring FreeBSD to feature parity with Linux on brightness management; it uses acpi_video(4) interface. The code was inspired by Junk-uk Kim's following patch: https://bugs.freedesktop.org/show_bug.cgi?id=24765
> I've used a generic #ifdef USE_SYSCTL to make it easy for other BSDs to add support for their system. initUsingSysctl(), m_device and m_levels are always defined to avoid spoiling backlighthelper.h with #ifdefs and definitions.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/upower/backlighthelper.h fe659e7 
>   powerdevil/daemon/backends/upower/backlighthelper.cpp 86b359a 
> 
> Diff: http://git.reviewboard.kde.org/r/106790/diff/
> 
> 
> Testing
> -------
> 
> Works fine on FreeBSD 10-CURRENT, even with my half broken ACPI (no LCD screen detected); shortcuts work, plasmoid slider works, power profiles work, and display dimming works as well (and is very welcome on my laptop). I've monitored brightness events via kded output, and everything works as expected (values rounding included).
> 
> 
> Thanks,
> 
> Alberto Villa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121011/dd7f3e2c/attachment.html>