[Kde-hardware-devel] Review Request: Hide Battery levels config altogether (instead of disabling it) when there is no battery

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106783/
-----------------------------------------------------------

(Updated Oct. 10, 2012, 3:33 p.m.)


Review request for Solid.


Changes
-------

Made the check a little bit more efficient. The actual battery count is not needed at all, we just need to know if there is a battery or not - so we can just exit the loop if we found one and use a bool :)


Description
-------

This little patch hides the config options for battery levels altogether when there is no battery present. Reducses visual clutter.


Diffs (updated)
-----

  powerdevil/kcmodule/global/GeneralPage.cpp 5ff3f4d 

Diff: http://git.reviewboard.kde.org/r/106783/diff/


Testing
-------

Didn’t test whether the elements are really hidden in the real condition (Have a notebook only here, but I know that if works) but commented out the if and the elements are all properly removed.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121010/5221b538/attachment.html>