[Kde-hardware-devel] Review Request: Prevent button action from always enabling dpms

[Oliver Henshaw]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106691/
-----------------------------------------------------------

Review request for Solid.


Description
-------

Prevent button action from always enabling dpms

DPMS needs to be enabled before a call to DPMSForceLevel, but it should not be
left on if it was previously disabled. Fix this in
PowerDevilDPMSAction::triggerImpl(), which is only called by the "Turn off
screen" button action.


Diffs
-----

  powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp a16bf7ee254b9a40c6f033c93e5ca63226469e6e 

Diff: http://git.reviewboard.kde.org/r/106691/diff/


Testing
-------

Tested interaction of powerbutton action and timed screen powersaving in 4.9.x VM.

Note: used virtual cirrus graphics, which claims to implement dpms but doesn't blank the screen - I used 'xset -q' to view dpms state.


Thanks,

Oliver Henshaw

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121002/9b9f8d57/attachment-0001.html>