[Kde-hardware-devel] Review Request: Tidy up PowerDevil notifyrc

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106689/#review19761
-----------------------------------------------------------

Ship it!


Good to go, thanks :)

- Dario Freddi


On Oct. 2, 2012, 1:55 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106689/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 1:55 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> That should be the last one ;)
> 
> This removes the notifications:
>  - inhibition. (Suspend job has been inhibited because an app requested it)
>    I could not find any cpp file in kde-workspace, kde-baseapps and kdelibs that uses this notification
>  - lockscreen/suspendjob (The screen is being locked)
>    I forgot to commit this with the last review. This has already been agreed on.
>  - joberror (There was an error while performing a job)
>    Could not find anyone that used that
> 
> Correct me if I overlooked something.
>    
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/bundled/suspendsession.cpp 8369413 
>   powerdevil/powerdevil.notifyrc 0e9ac81 
> 
> Diff: http://git.reviewboard.kde.org/r/106689/diff/
> 
> 
> Testing
> -------
> 
> Compiles and notification settings are much more tidy :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121002/abcd750c/attachment.html>