[Kde-hardware-devel] Review Request: Fix battery full notification not being emitted and make it watch for ChargeState rather than a charge percentage

Kai Uwe Broulik kde at privat.broulik.de
Tue Oct 2 11:21:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106686/
-----------------------------------------------------------

Review request for Solid and Dario Freddi.


Description
-------

This patch fixes battery notification not being emitted due to early return, and makes it watch for a change in ChargeState rather than the charge percentage which might not be reached at all.


Diffs
-----

  powerdevil/daemon/powerdevilcore.h 12e4b2c 
  powerdevil/daemon/powerdevilcore.cpp b968d21 

Diff: http://git.reviewboard.kde.org/r/106686/diff/


Testing
-------

Compiles.
Did not test if notification is properly emited, will do. Just wanted to know if this is the right approach.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121002/6dc292df/attachment-0001.html>


More information about the Kde-hardware-devel mailing list