[Kde-hardware-devel] Review Request: Make threshold for when the battery is considered full configurable (like you can with crtiical/low)

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106677/
-----------------------------------------------------------

Review request for Solid.


Description
-------

This patch adds the config option to set the threshold when the "Battery is full" notification should appear. Default is 100%.


This addresses bug 223553.
    http://bugs.kde.org/show_bug.cgi?id=223553


Diffs
-----

  powerdevil/PowerDevilSettings.kcfg cd103c6 
  powerdevil/daemon/powerdevilcore.cpp b968d21 
  powerdevil/kcmodule/global/GeneralPage.cpp 5ff3f4d 
  powerdevil/kcmodule/global/generalPage.ui 7840526 

Diff: http://git.reviewboard.kde.org/r/106677/diff/


Testing
-------

Config option works.
But the notification doesnt’t get triggered (also not without that patch). What did I miss in the if that checks for the battery percentage? Any idea?


Screenshots
-----------

KCM with third option (ordered descending)
  http://git.reviewboard.kde.org/r/106677/s/751/


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121001/31c2049f/attachment-0001.html>