[Kde-hardware-devel] Review Request: Only add DPMS to the profile if it is supported

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107503/#review22708
-----------------------------------------------------------

Ship it!


Good to go - we should probably have a more elegant solution than having ifdefs in the generator, but for now it will do :)

- Dario Freddi


On Nov. 28, 2012, 2:14 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107503/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 2:14 p.m.)
> 
> 
> Review request for Solid and Oliver Henshaw.
> 
> 
> Description
> -------
> 
> I found out that the Powerdevilprofilegenerator which is fired on first start of a KDE session which generates the profile and sets the defaults adds the DPMS action no matter if it is compiled or supported. That patch makes it only add it when it is compiled (HAVE_DPMS) and the action returns isSupported(). This will silence the most prominend warning about missing DPMS and having something in the config file which doesn't work is not good.
> Combined with the patch by Oliver Henshaw this will make PowerDevil not stick in your face on startup anymore (except for that Battery Low stuff I added :D which I am thinking of a fix)
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/powerdevilprofilegenerator.cpp 4cdbe11 
> 
> Diff: http://git.reviewboard.kde.org/r/107503/diff/
> 
> 
> Testing
> -------
> 
> Deleted my powermanagementrc, Tested *without* DPMS, works flawlessly. Cannot test with since I do not have DPMS support.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121128/d8c8a279/attachment.html>