[Kde-hardware-devel] Review Request: Silence "Profile foo could not activate bar which is a non-existent action" message

[Kai Uwe Broulik]

> On Nov. 18, 2012, 1:23 p.m., Kai Uwe Broulik wrote:
> > Great! Now that I have tested the Keyboard brightness support patch that is on Review Board atm, I get two error messages simultaneously on startup: One for DPMS, the other for Keyboard brightness. This really needs to be fixed/silenced …
> 
> Oliver Henshaw wrote:
>     I'm not sure what the Keyboard brightness problem is - that doesn't have a isSupported implementation as far as I can see. If you mean you've still got it in your config after removing the patch, isn't that the kind of misconfiguration that the notification is meant to warn about?
>     
>     Maybe invalid KConfigGroups shouldn't be persisted back to the configuration? Though maybe only for the NoAction case from the other review request, not for LoadFailed or NotSupported. Not really sure enough of how KConfigGroups work to tell whether that's a promising approach, though.

I think I will discard this request in favor of your implementation since yours also gives a feedback what happened and looks nicer :P
And yes, I think non-existent actions (ie. the config file references an action that is not availble due to not being compiled) should be dropped from the config file.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106863/#review22166
-----------------------------------------------------------


On Nov. 3, 2012, 2:46 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106863/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 2:46 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> That message usually appears when starting before the Desktop is up, causing an ugly 1990's passivepopup dialog on the screen, and its contents are not really novice-user-resolvable.
> On my machine it always claims "The profile Battery tried to activate DPMSControl which is a non-existent action.", which is when I compile powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not met here) and so the action floats around in the config but cannot be triggered anyways. (Imho this is a really infamous message, have seen it quite often on other machines *duck*). All the other actions seem to be installed anyways, so this missing action poses no threat. I guess a kWarning would be sufficient for this.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/CMakeLists.txt db9ca47 
>   powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 55689b5 
>   powerdevil/daemon/powerdevilactionpool.cpp a9950f1 
> 
> Diff: http://git.reviewboard.kde.org/r/106863/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> The previous passivepopup does not appear anymore. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121121/9ecef3f9/attachment-0001.html>