[Kde-hardware-devel] Review Request: Silence "Profile foo could not activate bar which is a non-existent action" message

[Oliver Henshaw]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106863/#review21653
-----------------------------------------------------------


I think all ActionPool::loadAction callers will need to check isSupported to be correct. Definitely the one in Core::loadProfile and the "DPMSControl" caller in HandleButtonEvents.

But see review #107257 for another approach. That one would still need your ifdef's to work when DPMS is compiled out.

- Oliver Henshaw


On Nov. 3, 2012, 2:46 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106863/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 2:46 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> That message usually appears when starting before the Desktop is up, causing an ugly 1990's passivepopup dialog on the screen, and its contents are not really novice-user-resolvable.
> On my machine it always claims "The profile Battery tried to activate DPMSControl which is a non-existent action.", which is when I compile powerdevil myself that DPMS stuff is not compiled (DPMS build requirements not met here) and so the action floats around in the config but cannot be triggered anyways. (Imho this is a really infamous message, have seen it quite often on other machines *duck*). All the other actions seem to be installed anyways, so this missing action poses no threat. I guess a kWarning would be sufficient for this.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/CMakeLists.txt db9ca47 
>   powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp 55689b5 
>   powerdevil/daemon/powerdevilactionpool.cpp a9950f1 
> 
> Diff: http://git.reviewboard.kde.org/r/106863/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> The previous passivepopup does not appear anymore. Did not test whether the kwarning is triggered, though. (Dunno how to get powerdevil debug console output)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121108/a6e919ae/attachment.html>