[Kde-hardware-devel] Review Request: Suggest a sane timeout in kcm when DPMS disabled

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107024/#review21308
-----------------------------------------------------------


This review has been submitted with commit ac6b13cc0bb03e550c8c993f5993b7b132d0f748 by Oliver Henshaw to branch push/4.9.

- Commit Hook


On Oct. 24, 2012, 4:35 p.m., Oliver Henshaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107024/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 4:35 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Suggest a sane timeout in kcm when DPMS disabled
> 
> Timeouts were changed from milliseconds to seconds in
> 02b29d95a281de8511dc81a038ff6007b5262eba but this one got corrupted on
> the way. The spinbox has a maximum value of 360 minutes, so this isn't
> as insane as it could have been.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/dpms/powerdevildpmsactionconfig.cpp 94de3808b25879876272463ab55f801a225dddc7 
> 
> Diff: http://git.reviewboard.kde.org/r/107024/diff/
> 
> 
> Testing
> -------
> 
> In powerdevil kcm, unticked "Screen Energy Saving". "Apply"ed and left the kcm. Returned to the kcm and checked that the greyed out spinbox contains "10 min"
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121101/9477ff4a/attachment-0001.html>