[Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

[Lamarque Vieira Souza]

> On June 20, 2012, 10:29 p.m., Lamarque Vieira Souza wrote:
> > solid/solid/powermanagement.cpp, line 236
> > <http://git.reviewboard.kde.org/r/105310/diff/1/?file=69989#file69989line236>
> >
> >     The famous default complaint: remove extra space, please.
> >     
> >     The rest of the code is Ok from my point of view, as long as you are right about the QDBusInterfaces are still valid if services disappears and reappears on the bus. Can you test that by restarting kded4? Use the kill -9 since it is a good way to similate a crash :-)
> 
> Daniel Nicoletti wrote:
>     hehe, I noticed the white space as soon as I opened the diff here :P
>     (which is why I love QtCreator so much)
>     Well I tested killing kded and the application using the interface behaved as expected,
>     which is why I said we didn't need new on this, tho now I remember having this issue
>     too on Apper but maybe QDBusInterface got fixed... I'll perform another tests as well.
>     BTW do you have any idea on why there is a weird connect on the register part? I think
>     we could just connect the signal on the constructor if there's no such signal it
>     will just fail.. ( I never saw an interface that can arbitrarily export signals,
>     so it just seems wrong..)

I usually do "<ESC>:%s:  *$::" in vim before closing my files :) You mean this connect? QDBusConnection::sessionBus().connect("org.kde.Solid.PowerManagement",
                                              "/org/kde/Solid/PowerManagement",
                                              "org.kde.Solid.PowerManagement",
                                              "resumingFromSuspend",
                                              this,
                                              SIGNAL(resumingFromSuspend()));
 
As long as the failed connect does not emit any warning message to polute the alreay poluted ~/.xsession-errors it looks Ok to me.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105310/#review14926
-----------------------------------------------------------


On June 20, 2012, 9:41 p.m., Daniel Nicoletti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105310/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 9:41 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Without this patch the appShouldConserResources() can't be trusted,
> if the DBus interface is not available or any other error occur
> we don't get the right values (normally it was true so Apper was
> prevented to check for new updates).
> This patch of course does fix other stuff which are related to the
> same problem.
> 
> 
> Diffs
> -----
> 
>   solid/solid/powermanagement.cpp 8dc8535 
>   solid/solid/powermanagement_p.h f39815d 
> 
> Diff: http://git.reviewboard.kde.org/r/105310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Nicoletti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20120621/fc2bac42/attachment.html>