[Kde-hardware-devel] Review Request: Make appShouldConserResources() reliable

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105310/#review14926
-----------------------------------------------------------



solid/solid/powermanagement.cpp
<http://git.reviewboard.kde.org/r/105310/#comment11719>

    The famous default complaint: remove extra space, please.
    
    The rest of the code is Ok from my point of view, as long as you are right about the QDBusInterfaces are still valid if services disappears and reappears on the bus. Can you test that by restarting kded4? Use the kill -9 since it is a good way to similate a crash :-)


- Lamarque Vieira Souza


On June 20, 2012, 9:41 p.m., Daniel Nicoletti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105310/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 9:41 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Without this patch the appShouldConserResources() can't be trusted,
> if the DBus interface is not available or any other error occur
> we don't get the right values (normally it was true so Apper was
> prevented to check for new updates).
> This patch of course does fix other stuff which are related to the
> same problem.
> 
> 
> Diffs
> -----
> 
>   solid/solid/powermanagement.cpp 8dc8535 
>   solid/solid/powermanagement_p.h f39815d 
> 
> Diff: http://git.reviewboard.kde.org/r/105310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Nicoletti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20120620/bcb8a10f/attachment.html>