[Kde-hardware-devel] Review Request: KScreen / KDED crashed when starting with unconfigured monitor (connected via DisplayPort)

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108031/#review24278
-----------------------------------------------------------


Ideally we should serialize only needed data, meaning that "If the output is not enabled, just store enabled: false".

Until we improve serialization (I plan to do it this week), can you modify your patch to something like:

if (output->isEnabled()) {
   mode stuff
}

- Àlex Fiestas


On Dec. 30, 2012, 5:24 p.m., Lukáš Karas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108031/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 5:24 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dan Vrátil.
> 
> 
> Description
> -------
> 
> When KDED with KScreen module starts with connected, but unitialized output (connected via DisplayPort in this case), kded crash due to NULL pointer dereference.
> 
> 	#6  0x00007f820730f68e in KScreen::Mode::refreshRate (this=0x0) at /media/data/cecko/KDE/libkscreen/src/mode.cpp:87
> 	#7  0x00007f8207560a82 in Serializer::saveConfig (config=0x1e25b20) at /media/data/cecko/KDE/kscreen/kded/serializer.cpp:115
> 	#8  0x00007f820755eba6 in KScreenDaemon::saveCurrentConfig (this=0x2192a50) at /media/data/cecko/KDE/kscreen/kded/daemon.cpp:101
> 	...
> 
> 
> With my patch is serialization of (null) mode skipped. Added debug outputs can be removed... With aplied patch is output follows:
> 
> 	Finding a mode with:  
> 	QSize(0, 0) 
> 	"" 
> 	Finding a mode with:  
> 	QSize(1600, 900) 
> 	"60" 
> 	1 
> 	Change detected 
> 	Scheduling screen save 
> 	Screen property change detected! 
> 	Monitor change detected 
> 	Saving current config 
> 	Could not found mode id 0 on output "DP3" 
> 	All modes: 
> 	111 : "640x480" 
> 	75 : "1440x900" 
> 	112 : "720x400" 
> 	79 : "1024x768" 
> 	...
> 	110 : "640x480" 
> 	2 
> 	Config saved on:  "/home/karry/.kde/share/apps/kscreen/7deb1978bbf838a0b702d57fef4e36cba0b702d57fef4e36cb" 
> 
> 
> Diffs
> -----
> 
>   kded/serializer.cpp 62dde51 
> 
> Diff: http://git.reviewboard.kde.org/r/108031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukáš Karas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121230/a93befa6/attachment.html>