[Kde-hardware-devel] Review Request: Semantic change in XRandROutput::edid() and select the first preferred mode found for a montior

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107940/
-----------------------------------------------------------

(Updated Dec. 27, 2012, 12:36 p.m.)


Review request for Solid, Àlex Fiestas and Dan Vrátil.


Description
-------

The change in XRandROutput::edid() allows us to use "if (edid->isValid())" instead of "if (edid && edid->isValid())". I think the former is cleaner.

The change in XRandROutput::updateModes() selects the first preferred mode found instead of the last one. At least in my notebook the first preferred mode has higher resolution, probably that is also valid for all modes returned by XRandR API.


Diffs
-----

  backends/xrandr/xrandroutput.cpp dc2555b 

Diff: http://git.reviewboard.kde.org/r/107940/diff/


Testing
-------

Tested in my notebook. The change in XRandROutput::edid() is part of a crash fix for kscreen. The change in XRandROutput::updateModes() fixes a problem in my notebook's lcd, which includes several preferred modes and the last mode is the one with lower resolution.


Thanks,

Lamarque Vieira Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121227/1bd73f01/attachment.html>