[Kde-hardware-devel] Review Request: Set dbus timeout for the unmount call to infinite

[Kevin Ottens]

> On Sept. 9, 2011, 6:44 p.m., Dario Freddi wrote:
> > solid/solid/backends/udisks/udisksstorageaccess.cpp, line 298
> > <http://git.reviewboard.kde.org/r/101428/diff/2/?file=30936#file30936line298>
> >
> >     Don't know if this patch has been submitted yet, but just in case, this call should be really replaced with an asyncCall, which also handles timeouts and long calls way more efficiently. I can fix that for you if you like.

Not quite, even with an async call you'd get hit by the D-Bus timeout (20 seconds by default) if the end point fails to reply before it hits, which is very common for the unmount case.

Of course doing it async would be a nice improvement to the patch, but the extended timeout would still be needed... otherwise we'd still get the same error than before, just in an async way. :-)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101428/#review6361
-----------------------------------------------------------


On Aug. 7, 2011, 8:19 a.m., Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101428/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 8:19 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Summary
> -------
> 
> Occasionally, when a long flush is taking place, the dbus call to unmount will timeout; the user receives a timeout message and 
> does not know when it is safe to unplug the device anymore. This is due to a flaw in udisks api, which should not use replies but 
> signals, and will be reported shortly upstream.
> Meanwhile this is a reasonable workaround while we wait for new api
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udisks/udisksstorageaccess.h 6bf729c 
>   solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7c 
> 
> Diff: http://git.reviewboard.kde.org/r/101428/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo De
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110909/5e0266bf/attachment.html>