[Kde-hardware-devel] Review Request: Set dbus timeout for the unmount call to infinite

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101428/#review7470
-----------------------------------------------------------


This review has been submitted with commit 2565770034dc5c20e192925c7c8e4af3f03aadf0 by Lukas Tinkl to branch frameworks.

- Commit Hook


On Aug. 7, 2011, 8:19 a.m., Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101428/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 8:19 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> Occasionally, when a long flush is taking place, the dbus call to unmount will timeout; the user receives a timeout message and 
> does not know when it is safe to unplug the device anymore. This is due to a flaw in udisks api, which should not use replies but 
> signals, and will be reported shortly upstream.
> Meanwhile this is a reasonable workaround while we wait for new api
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udisks/udisksstorageaccess.h 6bf729c 
>   solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7c 
> 
> Diff: http://git.reviewboard.kde.org/r/101428/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo De Simoi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20111018/816c4980/attachment.html>