[Kde-hardware-devel] Review Request: Do not return descriptions for devices with duplicate vendor if the model already starts with the vendor name

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102907/#review7465
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Oct. 18, 2011, 4:36 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102907/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 4:36 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> When plugging my N950 solid reports 
> Nokia Nokia N950 as description for the device and shows in various places in the UI (dolphin, device notifier)
> I am suggesting removing the first Nokia
> 
> My initial patch had
> if (model.startsWith(vendor_str + " "))
> instead of
> if (model.startsWith(vendor_str))
> I'm open to discussion on how to improve the check
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udisks/udisksdevice.cpp c76eebc 
> 
> Diff: http://git.reviewboard.kde.org/r/102907/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20111018/0bea5144/attachment.html>