[Kde-hardware-devel] Re: Review Request: Call onBrightnessChanged only on brightnessKeyPressed

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101330/#review3261
-----------------------------------------------------------


This review has been submitted with commit 918f7eed82c00b3b4adf88f97269bc087b599d6c by Alex Fiestas.

- Commit


On May 10, 2011, 8:40 a.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101330/
> -----------------------------------------------------------
> 
> (Updated May 10, 2011, 8:40 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> The only use-case where we actually need the osd brightness indicator to be shown is when the brightness change is triggered by brightnessKeyPressed. This patch move the onBrightnessChanged call (from backend to core) to brightnessKeyPressed instead of in setBrightness
> 
> If this patch is ok to go, I will make the same change into hal backend.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 6d8c055 
> 
> Diff: http://git.reviewboard.kde.org/r/101330/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110511/9e0c80a1/attachment.htm