[Kde-hardware-devel] Re: Review Request: Call onBrightnessChanged only on brightnessKeyPressed

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101330/#review3257
-----------------------------------------------------------

Ship it!


Looks sensible - in the long term, I'd like to move OSD handling out of the applet and into the daemon for doing the right thing... I also had a patch ready somewhere, but reality catched up with me :(

P.S.: Protip: you can also assign review requests to users, so that I can see it more quickly :) Thanks for the mail btw!

- Dario


On May 10, 2011, 8:40 a.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101330/
> -----------------------------------------------------------
> 
> (Updated May 10, 2011, 8:40 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> The only use-case where we actually need the osd brightness indicator to be shown is when the brightness change is triggered by brightnessKeyPressed. This patch move the onBrightnessChanged call (from backend to core) to brightnessKeyPressed instead of in setBrightness
> 
> If this patch is ok to go, I will make the same change into hal backend.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 6d8c055 
> 
> Diff: http://git.reviewboard.kde.org/r/101330/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110511/bbc2cf65/attachment.htm