[Kde-hardware-devel] Re: Review Request: Call onBrightnessChanged only on brightnessKeyPressed

[Alex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101330/
-----------------------------------------------------------

(Updated May 10, 2011, 8:33 a.m.)


Review request for Solid.


Changes
-------

Build++


Summary
-------

The only use-case where we actually need the osd brightness indicator to be shown is when the brightness change is triggered by brightnessKeyPressed. This patch move the onBrightnessChanged call (from backend to core) to brightnessKeyPressed instead of in setBrightness

If this patch is ok to go, I will make the same change into hal backend.


Diffs (updated)
-----

  powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 6d8c055 

Diff: http://git.reviewboard.kde.org/r/101330/diff


Testing
-------


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110510/b3b790ff/attachment-0001.htm