[Kde-hardware-devel] Re: Review Request: Fill in vendor and model names using Solid's udev backend when possible

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101270/
-----------------------------------------------------------

(Updated May 2, 2011, 1:28 p.m.)


Review request for Solid, Kevin Ottens and Alex Fiestas.


Changes
-------

Move the QFile::exists() check into udev backend. solid-hardware list now list all available devices.


Summary
-------

solid-hardware does not report my 3G modem's vendor and model names. This patch fix that:

[lamarque at evolucao ~]$ solid-hardware details /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1
udi = '/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1'
  parent = '/org/kde/solid/udev'  (string)
  vendor = 'Sony Ericsson'  (string)
  product = 'Sony Ericsson MD300'  (string)
  description = ''  (string)
  Block.major = 189  (0xbd)  (int)
  Block.minor = 175  (0xaf)  (int)
  Block.device = '/dev/bus/usb/002/048'  (string)

The patch basically tests if /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1 exists, if affirmative it creates a UDevDevice, which makes it possible to report the available device details instead of just ignoring them completely.

'solid-hardware list' still does not list the device. I am still not sure if I should fix that since it would give the false impression the device is supported.

The motivation for this change is Plasma NM. The patch allows me inform modem's vendor and model names
in Mobile Connection Wizard (when creating Gsm/Cdma connections) and in PinDialog (when requesting PIN unlock code from user). It is basically usability fix.


Diffs (updated)
-----

  solid/solid/backends/udev/udevdevice.cpp 4f34382 
  solid/solid/backends/udev/udevmanager.cpp e08fcde 

Diff: http://git.reviewboard.kde.org/r/101270/diff


Testing
-------

I have been using kdelibs-4.6.2 compiled with the patch since yesterday, not problems so far.


Thanks,

Lamarque Vieira

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110502/5ee04e4b/attachment.htm