[Kde-hardware-devel] Re: Review Request: Add NetworkShare interface

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100815/#review1852
-----------------------------------------------------------


A few adjustments are needed IMO.


solid/solid/backends/upower/upowerdeviceinterface.h
<http://git.reviewboard.kde.org/r/100815/#comment1519>

    s/UDisks/UPower/ I guess.



solid/solid/deviceinterface.h
<http://git.reviewboard.kde.org/r/100815/#comment1514>

    s/reader//



solid/solid/deviceinterface.cpp
<http://git.reviewboard.kde.org/r/100815/#comment1515>

    s/NetworkShare Interface/Network Share/



solid/solid/networkshare.h
<http://git.reviewboard.kde.org/r/100815/#comment1516>

    Should be named "ShareType" IMO. And "Undefined" should be "Unknown", please also for the value for Unknown to 0. Also please add a Upnp type which the UPnP backend will use.
    
    I'm not quite sure about Smb, shouldn't it be Cifs? Opinions? Smb looks too linux centric to me, that's fine on the backend side, not on the frontend API.



solid/solid/networkshare.h
<http://git.reviewboard.kde.org/r/100815/#comment1517>

    s/network/network share/



solid/solid/networkshare.h
<http://git.reviewboard.kde.org/r/100815/#comment1518>

    ditto


- Kevin


On March 7, 2011, 4:38 p.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100815/
> -----------------------------------------------------------
> 
> (Updated March 7, 2011, 4:38 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> - Add the NetworkShare interface to determine the network protocol used.
> - Use this interface in fstab backend to determine if we have a nfs or 
>   smb mount point.
> 
> 
> Diffs
> -----
> 
>   solid/solid/CMakeLists.txt 46adea8 
>   solid/solid/backends/fakehw/fakedevice.cpp 94455ed 
>   solid/solid/backends/fstab/fstabdevice.cpp efc085d 
>   solid/solid/backends/fstab/fstabmanager.cpp 68e8d8b 
>   solid/solid/backends/fstab/fstabnetworkshare.h PRE-CREATION 
>   solid/solid/backends/fstab/fstabnetworkshare.cpp PRE-CREATION 
>   solid/solid/backends/hal/haldevice.cpp 56823f6 
>   solid/solid/backends/hal/haldeviceinterface.h 240017b 
>   solid/solid/backends/udisks/udisksdeviceinterface.h 42a88a8 
>   solid/solid/backends/upower/upowerdeviceinterface.h 6608ab3 
>   solid/solid/backends/wmi/wmideviceinterface.h 99437e5 
>   solid/solid/backends/wmi/wmimanager.cpp 41c7274 
>   solid/solid/device.cpp 54135d8 
>   solid/solid/deviceinterface.h c04bbf4 
>   solid/solid/deviceinterface.cpp 375ae37 
>   solid/solid/ifaces/networkshare.h PRE-CREATION 
>   solid/solid/ifaces/networkshare.cpp PRE-CREATION 
>   solid/solid/networkshare.h PRE-CREATION 
>   solid/solid/networkshare.cpp PRE-CREATION 
>   solid/solid/networkshare_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100815/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110308/76e933ad/attachment.htm