[Kde-hardware-devel] Review Request: Fix Dolphin not showing the unlocked container after first mount of an encrypted container

[Ozan Çağlayan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101160/
-----------------------------------------------------------

Review request for Solid, Alex Fiestas and Lukáš Tinkl.


Summary
-------

When you *first* mount an encrypted container and enter the passphrase correctly, Dolphin is launched through SolidUiServer with:

kioclient exec %f

after the setupDone() signal is emitted. But the signal is emitted right after the async D-Bus call which mounts the slave filesystem,
causing the %f to be expanded to an empty string returned by UDisksStorageAccess::filePath(). This causes Dolphin to show the Home directory
instead of the just-mounted filesystem.

Encapsulate the "signal emitting" in else {} block to cure this problem.


This addresses bug 271156.
    http://bugs.kde.org/show_bug.cgi?id=271156


Diffs
-----

  solid/solid/backends/udisks/udisksstorageaccess.cpp 7dd25ea 

Diff: http://git.reviewboard.kde.org/r/101160/diff


Testing
-------

Tested on KDE 4.6.2 with
 - an encrypted container
 - a normal usb flash disk

and works OK.


Thanks,

Ozan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110420/1a814689/attachment.htm