[Kde-hardware-devel] Re: Review Request: UDev: provide DvbInterface implementation

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5993/#review9018
-----------------------------------------------------------

Ship it!


Minor nitpicks, otherwise I didn't see anything inherently wrong. Please address those issues and commit (also keep in mind I can't test this patch, I lack DVB hardware).


/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.h
<http://svn.reviewboard.kde.org/r/5993/#comment9771>

    Copyright is likely wrong now, right?



/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.h
<http://svn.reviewboard.kde.org/r/5993/#comment9770>

    s/HAL/UDEV/?



/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.cpp
<http://svn.reviewboard.kde.org/r/5993/#comment9772>

    Copyright issue again?


- Kevin


On 2010-11-28 11:08:45, Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5993/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 11:08:45)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> This is a first implementation of DvbInterface for the udev backend.
> 
> Allows devices of subsystem "dvb" among the ones that the udev backend shows, and for them it provides a DvbInterface implementation (which is basically copied from the HAL one, with s/hal/udev/ and the right property to query for the device name, so I will do svn cp for it).
> What is missing is an icon and a description for dvb devices, mostly because of the string freeze. (At least to me, HAL returns a "DVB Device" string for all the dvb devices reported, so in case it would be the same for the udev backend.)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1201550 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp 1201550 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1201550 
> 
> Diff: http://svn.reviewboard.kde.org/r/5993/diff
> 
> 
> Testing
> -------
> 
> Kaffeine sees and recognizes my DVB device, allowing me to use it.
> 
> 
> Thanks,
> 
> Pino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101128/bb95ab79/attachment.htm