[Kde-hardware-devel] Re: Review Request: Implement full Processor support in UDev backend

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5892/#review8971
-----------------------------------------------------------


Almost there! Only a tiny styling issue (sorry for not spotting it earlier), and a proposal for handling the caching slightly differently. Next revision should be good to go.


/trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.h
<http://svn.reviewboard.kde.org/r/5892/#comment9714>

    s/QString& /QString &/ (whitespace on the wrong side)



/trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.cpp
<http://svn.reviewboard.kde.org/r/5892/#comment9715>

    s/QString& /QString &/



/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.cpp
<http://svn.reviewboard.kde.org/r/5892/#comment9716>

    Please remove the const_cast and make m_maxSpeed mutable instead (that's more the pattern for caches).



/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.cpp
<http://svn.reviewboard.kde.org/r/5892/#comment9717>

    Please remove the const_cast and make m_canChangeFrequency mutable instead.


- Kevin


On 2010-11-24 23:30:04, Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5892/
> -----------------------------------------------------------
> 
> (Updated 2010-11-24 23:30:04)
> 
> 
> Review request for Solid and Rafael Fernández López.
> 
> 
> Summary
> -------
> 
> Implement support for all attributes of the Processor interface when using UDev.
> 
> With this patch, the udev backend does better than the hal one (notably, with linux 2.6.36, HAL's reporting of the throttling ability of a processor will break, as /proc/acpi/CPUX/info is removed in that kernel version; also, HAL does not report the processor vendor).
> 
> It might be good to do some caching of values, since there is a lot of opening and parsing files (although the opening and reading part should be fast on virtual filesystems, and there isn't a whole lot of text to parse).
> 
> 
> This addresses bug 253667.
>     https://bugs.kde.org/show_bug.cgi?id=253667
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/shared/udevqt.h 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/shared/udevqtdevice.cpp 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.h 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.h 1199450 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.cpp 1199450 
> 
> Diff: http://svn.reviewboard.kde.org/r/5892/diff
> 
> 
> Testing
> -------
> 
> Reports information correctly on my computer.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101125/f9ca9d98/attachment-0001.htm