[Kde-hardware-devel] Re: Review Request: Add (limited) Portable Media Player support to Solid udev backend

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5853/#review8954
-----------------------------------------------------------


I'm discarding this as it produces unuseful results (the PMP interface appears completely unrelated to the storage devices attached to it).

- Alex


On 2010-11-16 02:55:10, Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5853/
> -----------------------------------------------------------
> 
> (Updated 2010-11-16 02:55:10)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> Adds support to the Solid udev backend for Portable Media Players.  Providing the user has media-player-info installed, the functionality should be identical to the hal backend in the case where libmtp is not installed.
> 
> libmtp provides HAL with extra information about the media devices it can deal with.  There is no clear way to access that information without HAL - I've filed bugs with media-player-info and libmtp about that, so we'll see where that goes.
> 
> The other issue (as may be apparent from the code) is that gphoto2's udev rules interfere with media-player-info's rules by also setting ID_MEDIA_PLAYER.  media-player-info stores useful information under this key, while gphoto2 just sets it to 1 if it recognises the device.  There are 14 overlapping devices currently, and if gphoto2's rules are parsed after media-player-info's rules, the media-player-info details will be overwritten for these devices.  Again, I've filed bugs with the relevant projects about this.
> 
> 
> This addresses bug 253671.
>     https://bugs.kde.org/show_bug.cgi?id=253671
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1196931 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp 1196931 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1196931 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevportablemediaplayer.h 1196931 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevportablemediaplayer.cpp 1196931 
>   /trunk/KDE/kdelibs/solid/solid/xdgbasedirs.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/xdgbasedirs_p.h PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5853/diff
> 
> 
> Testing
> -------
> 
> solid-hardware lists "storage" as a supported protocol for my Sansa Clip+ when it's operating in MSC (storage) mode.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101124/1210d507/attachment.htm