[Kde-hardware-devel] Re: KDE/kdelibs/solid/solid

[Raphael Kubo da Costa]

On Tuesday 16 November 2010 14:20:52 Lukáš Tinkl wrote:
> Dne Út 16. listopadu 2010 16:31:28 jste napsal(a): > On Tuesday 16 November
> 
> 2010 09:58:16 Lukáš Tinkl wrote:
> > > Dne Út 16. listopadu 2010 00:44:02 Raphael Kubo da Costa napsal(a):
> > > > SVN commit 1197469 by rkcosta:
> > > > 
> > > > Only build the udisks backend on Linux.
> > > > 
> > > > Recent commits added a hard dependency on linux_dvd_rw_utils.{c,h}
> > > > that cannot be #ifdef'ed with Q_OS_LINUX. Until that is fixed, we
> > > > need to skip the udisks backend for kdelibs to build again on
> > > > OpenSolaris, FreeBSD and other non-Linux Unixes.
> > > > 
> > > > CCMAIL: lukas at kde.org
> > > > CCMAIL: kde-hardware-devel at kde.org
> > > 
> > > Why not add a simple "if not linux" cmake switch?
> > 
> > Sorry, I didn't understand what you meant. Do you mean something like
> > 
> >   if (not on linux)
> >   
> >     do_something
> >   
> >   endif (not on linux)
> > 
> > instead of
> > 
> >   if (on linux)
> >   
> >     add udisks stuff
> >   
> >   endif (on linux)
> > 
> > ?
> 
> Yes, of course, I meant "if on linux" :) That way the udisks backend gets
> only added for Linux and doesn't fail on other Unixes

In this case, how is it any different from what has been committed?