[Kde-hardware-devel] Review Request: Add two more methods to Battery: capacity and hasRecallNotice

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5814/
-----------------------------------------------------------

Review request for Solid and Kevin Ottens.


Summary
-------

This patch adds two new more methods to Battery, capacity and hasRecallNotice, and a working upower implementation.

I plan on researching the other backends' implementations as well before 4.6 is released, but given the incoming freezes I'd like the API to get in ASAP.


This addresses bug 218546.
    https://bugs.kde.org/show_bug.cgi?id=218546


Diffs
-----

  /trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.h 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.cpp 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.h 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.h 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.cpp 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.h 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.cpp 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.h 1194840 
  /trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.cpp 1194840 
  /trunk/KDE/kdelibs/solid/solid/battery.h 1194840 
  /trunk/KDE/kdelibs/solid/solid/battery.cpp 1194840 
  /trunk/KDE/kdelibs/solid/solid/ifaces/battery.h 1194840 

Diff: http://svn.reviewboard.kde.org/r/5814/diff


Testing
-------


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101110/70550611/attachment-0001.htm