[Kde-hardware-devel] Re: Review Request: Few minor improvments for UDisks solid backend manager...

Dawit Alemayehu adawit at kde.org
Tue Nov 9 18:02:31 CET 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-11-09 17:02:31.081222)

Review request for Solid.


More white space fixes...


The attached patch does the following:

1.) Remove the call to allDevices() from UDisksManager's ctor. Instead a new
private method is added to properly initialize the devices list cache before

2.) Remove the 'result' variable from UDisksManager::allDevices since it is
unnecessary and m_deviceCache can be used directly.

3.) Other minor namespace (foreach -> Q_FOREACH) and macro-performance (moving
the call for propertyCount() out of the for loop.

Note that the Bug number above is only mentioned as a reference to point out the origins of the attached patches...

This addresses bug 253039.

Diffs (updated)

  trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksdevice.cpp 1192709 
  trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.h 1192709 
  trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp 1192709 

Diff: http://svn.reviewboard.kde.org/r/5797/diff




-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101109/b9b7489e/attachment.htm 

More information about the Kde-hardware-devel mailing list