[Kde-hardware-devel] Re: Review Request: Few minor improvments for UDisks solid backend manager...

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5797/#review8571
-----------------------------------------------------------


Only minor whitespace issues. Also could you remove the foreach->Q_FOREACH changes, I don't see the point of it and we're using foreach everywhere else in the lib.


trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.h
<http://svn.reviewboard.kde.org/r/5797/#comment8958>

    s/QStringList& /QStringList &/
    
    (I know the backend is kind of not homogeneous there, but that's the style used in libsolid).



trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp
<http://svn.reviewboard.kde.org/r/5797/#comment8959>

    Please use the opportunity to fix the style... s/QString & /QString &/.



trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp
<http://svn.reviewboard.kde.org/r/5797/#comment8960>

    Ditto.
    
    *sigh* I hate large code drops. ;-)



trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp
<http://svn.reviewboard.kde.org/r/5797/#comment8961>

    Ditto.


- Kevin


On 2010-11-08 07:39:06, Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5797/
> -----------------------------------------------------------
> 
> (Updated 2010-11-08 07:39:06)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> The attached patch does the following:
> 
> 1.) Remove the call to allDevices() from UDisksManager's ctor. Instead a new
> private method is added to properly initialize the devices list cache before
> use.
> 
> 2.) Remove the 'result' variable from UDisksManager::allDevices since it is
> unnecessary and m_deviceCache can be used directly.
> 
> 3.) Other minor namespace (foreach -> Q_FOREACH) and macro-performance (moving
> the call for propertyCount() out of the for loop.
> 
> Note that the Bug number above is only mentioned as a reference to point out the origins of the attached patches...
> 
> 
> This addresses bug 253039.
>     https://bugs.kde.org/show_bug.cgi?id=253039
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksdevice.cpp 1192709 
>   trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.h 1192709 
>   trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp 1192709 
> 
> Diff: http://svn.reviewboard.kde.org/r/5797/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101108/e6f5f630/attachment.htm